Skip to content

Prevent ObjectFlags.IdenticalBaseTypeExists and ObjectFlags.IsConstrainedTypeVariable confusion#56711

Merged
jakebailey merged 2 commits intomicrosoft:mainfrom
Andarist:fix/remove-constrained-type-variables-crash
Dec 11, 2023
Merged

Prevent ObjectFlags.IdenticalBaseTypeExists and ObjectFlags.IsConstrainedTypeVariable confusion#56711
jakebailey merged 2 commits intomicrosoft:mainfrom
Andarist:fix/remove-constrained-type-variables-crash

Conversation

@Andarist
Copy link
Contributor

@Andarist Andarist commented Dec 8, 2023

fixes #56688

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Dec 8, 2023
@typescript-bot typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Dec 11, 2023
@Andarist
Copy link
Contributor Author

I managed to add a test case for this so the PR is ready for a full review :)

@Andarist Andarist requested a review from jakebailey December 11, 2023 08:58
@jakebailey jakebailey merged commit 5b10466 into microsoft:main Dec 11, 2023
@Andarist Andarist deleted the fix/remove-constrained-type-variables-crash branch December 11, 2023 18:27
c0sta pushed a commit to c0sta/TypeScript that referenced this pull request Dec 20, 2023
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash on 5.4.0-dev.20231206

3 participants